Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add top level argument type in generated file #3794

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

natebosch
Copy link
Member

@natebosch natebosch commented Jan 6, 2025

Clean up the last instance of ^Builder.*(_) after the same pattern was
changed everywhere else to adhere to the strict top level inference
lint.

Add the BuilderOptions annotation in a string being written as a
top level function in a generated file.

There do not appear to be instances of this pattern in documentation.

Clean up the last instance of `^Builder.*(_)` after the same pattern was
changed everywhere else to adhere to the strict top level inference
lint.

There do not appear to be instances of this pattern in documentation.
@natebosch natebosch requested a review from jakemac53 January 6, 2025 19:07
Copy link

github-actions bot commented Jan 6, 2025

PR Health

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

@natebosch natebosch merged commit e896622 into master Jan 6, 2025
73 of 77 checks passed
@natebosch natebosch deleted the codegen-strict-inference branch January 6, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants